DanielCarter-stack commented on PR #10367:
URL: https://github.com/apache/seatunnel/pull/10367#issuecomment-3769581217
<!-- code-pr-reviewer -->
- `JdbcDialect.java:228-241` (getUpsertStatement) - JavaDoc missing @param
tags for database/tableName/fieldNames/pkNames after parameter rename; affects
API doc generation and IDE hints, though runtime behavior is unchanged.
```java
228: /**
229: * Constructs the dialects upsert statement if supported; such as
MySQL's {@code DUPLICATE KEY
230: * UPDATE}, or PostgreSQL's {@code ON CONFLICT... DO UPDATE SET..
```
- `PostgresDialectTest.java:33-36` - Local variables named
`doUpdateKeyFields`/`doNothingKeyFields` don't match API parameter name
`pkNames`, reducing test code readability and maintainability.
```java
33: final String[] doUpdateKeyFields = {"id"};
34: final String[] doNothingKeyFields = {
35: "id", "type", "role_name", "description", "create_time",
"update_time"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
