dybyte commented on code in PR #10367:
URL: https://github.com/apache/seatunnel/pull/10367#discussion_r2708934516
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/dm/DmdbDialect.java:
##########
@@ -79,18 +79,18 @@ public JdbcDialectTypeMapper getJdbcDialectTypeMapper() {
@Override
public Optional<String> getUpsertStatement(
- String database, String tableName, String[] fieldNames, String[]
uniqueKeyFields) {
+ String database, String tableName, String[] fieldNames, String[]
pkNames) {
List<String> nonUniqueKeyFields =
Review Comment:
Would `nonPkFields` be a better name than `nonUniqueKeyFields`?
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/kingbase/KingbaseDialect.java:
##########
@@ -46,11 +46,9 @@ public JdbcDialectTypeMapper getJdbcDialectTypeMapper() {
@Override
public Optional<String> getUpsertStatement(
- String database, String tableName, String[] fieldNames, String[]
uniqueKeyFields) {
+ String database, String tableName, String[] fieldNames, String[]
pkNames) {
String uniqueColumns =
Review Comment:
Would `pkColumns` be a better name than `uniqueColumns`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
