chl-wxp commented on PR #10370: URL: https://github.com/apache/seatunnel/pull/10370#issuecomment-3771336625
> * seatunnel-api/src/main/java/org/apache/seatunnel/api/options/table/CatalogOptions.java:72-73 - The deprecation message has formatting and typo issues. Missing punctuation after `TABLE_CONFIGS` and "structed" should be "structured". This reduces JavaDoc readability and may confuse users about the migration path. > * docs/en/connectors/source/Maxcompute.md, Paimon.md, StarRocks.md - Missing migration guide for the deprecated `table_list` parameter. Since `CatalogOptions.TABLE_LIST` is marked `@Deprecated`, users need clear guidance on how to migrate to `tables_configs` to avoid configuration errors. > * seatunnel-api/src/main/java/org/apache/seatunnel/api/options/table/TableSchemaOptions.java:41-42 - Contradictory parameter descriptions. `TABLE_LIST` claims to act on "structed" [structured] data sources, while `TABLE_CONFIGS` claims "unstructed" [unstructured] data sources. Yet the deprecation notice suggests replacing `TABLE_LIST` with `TABLE_CONFIGS`, creating confusion about which parameter to use and risking misconfiguration. > * seatunnel-connectors-v2/connector-jdbc/config/JdbcSourceOptions.java, connector-doris/config/DorisSourceOptions.java, etc. - The refactoring is incomplete. While the PR title claims to unify non-relational data source multi-table schema parameters, only MaxCompute, Paimon, and StarRocks were updated. JDBC, Doris, Iceberg, Hudi, and ClickHouse still define their own `TABLE_LIST` constants, creating architectural inconsistency. doris does not use `schema` configuration -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
