chl-wxp commented on code in PR #10370:
URL: https://github.com/apache/seatunnel/pull/10370#discussion_r2710634775
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/options/table/CatalogOptions.java:
##########
@@ -59,11 +59,16 @@ public interface CatalogOptions {
"The table names RegEx of the database to capture."
+ "The table name needs to include the
database name, for example: database_.*\\.table_.*");
+ /**
+ * This parameter is deprecated, please use parameter:
TableSchemaOptions.TABLE_CONFIGS. {@link
+ * org.apache.seatunnel.api.options.table.TableSchemaOptions}
+ */
+ @Deprecated
Option<List<Map<String, Object>>> TABLE_LIST =
Options.key("table_list")
.type(new TypeReference<List<Map<String, Object>>>() {})
.noDefaultValue()
.withDescription(
- "SeaTunnel Multi Table Schema, acts on structed
data sources. "
+ "This parameter is deprecated, please use
parameter: TableSchemaOptions.TABLE_CONFIGS.SeaTunnel Multi Table Schema, acts
on structed data sources. "
+ "such as jdbc, paimon, doris, etc");
Review Comment:
> The `table_configs` option is currently described as for `unstructured
data sources`. I’m a bit concerned that if this option is deprecated, it might
be unclear which option should be used for `structured data sources`. Would it
make sense to clarify this to avoid potential confusion?
The reason why I marked TABLE_LIST obsolete is as follows:
1. The definition of `TableSchemaOptions.TABLE_CONFIGS` and the definition
of `TABLE_LIST` are duplicated. In fact, there should be only one, and all
relational data sources should use the same set of parameters;
2. If new non-relational components are introduced later, `TABLE_LIST` is
not allowed to be used;
3. Now some non-relational connector sources, such as `paimon`, already use
`TABLE_LIST` and need to be compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
