yzeng1618 commented on code in PR #10419:
URL: https://github.com/apache/seatunnel/pull/10419#discussion_r2744775148
##########
seatunnel-core/seatunnel-flink-starter/seatunnel-flink-starter-common/src/main/java/org/apache/seatunnel/core/starter/flink/AbstractFlinkStarter.java:
##########
@@ -65,7 +64,13 @@ public List<String> buildCommands() {
if (flinkCommandArgs.getMasterType() == MasterType.YARN_APPLICATION) {
command.add(
String.format("-Dyarn.ship-files=\"%s\"",
flinkCommandArgs.getConfigFile()));
- command.add(String.format("-Dyarn.ship-archives=%s",
RUNTIME_FILE));
+ command.add(
+ String.format(
+ "-Dyarn.ship-archives=%s",
Review Comment:
After converting -Dyarn.ship-archives to an absolute path, omitting
quotation marks may cause shell word splitting at this position. It is
recommended to change it to String.format("-Dyarn.ship-archives=\"%s\"", path).
##########
seatunnel-core/seatunnel-flink-starter/seatunnel-flink-13-starter/src/main/bin/start-seatunnel-flink-13-connector-v2.sh:
##########
@@ -44,7 +44,7 @@ if [ -f "${CONF_DIR}/seatunnel-env.sh" ]; then
fi
if [ ! -f "${APP_DIR}/runtime.tar.gz" ];then
-
+ cd "${APP_DIR}"
Review Comment:
The cd command is only executed when runtime.tar.gz does not exist, which
causes the script’s working directory to be inconsistent between the first run
and subsequent runs. It is recommended to replace cd "${APP_DIR}" with tar -C
"${APP_DIR}" ... (or restore the original working directory after packaging) to
ensure stable behavior.
##########
seatunnel-core/seatunnel-flink-starter/seatunnel-flink-15-starter/src/main/bin/start-seatunnel-flink-15-connector-v2.sh:
##########
@@ -44,7 +44,7 @@ if [ -f "${CONF_DIR}/seatunnel-env.sh" ]; then
fi
if [ ! -f "${APP_DIR}/runtime.tar.gz" ];then
-
+ cd "${APP_DIR}"
Review Comment:
ditto
##########
seatunnel-core/seatunnel-flink-starter/seatunnel-flink-20-starter/src/main/bin/start-seatunnel-flink-20-connector-v2.sh:
##########
@@ -44,7 +44,7 @@ if [ -f "${CONF_DIR}/seatunnel-env.sh" ]; then
fi
if [ ! -f "${APP_DIR}/runtime.tar.gz" ];then
-
+ cd "${APP_DIR}"
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
