LiJie20190102 commented on code in PR #10419:
URL: https://github.com/apache/seatunnel/pull/10419#discussion_r2745454627
##########
seatunnel-core/seatunnel-flink-starter/seatunnel-flink-13-starter/src/main/bin/start-seatunnel-flink-13-connector-v2.sh:
##########
@@ -44,7 +44,7 @@ if [ -f "${CONF_DIR}/seatunnel-env.sh" ]; then
fi
if [ ! -f "${APP_DIR}/runtime.tar.gz" ];then
-
+ cd "${APP_DIR}"
Review Comment:
Thank you for reminding me. What if we add this step?
<img width="656" height="483" alt="image"
src="https://github.com/user-attachments/assets/e82cddaf-1c38-489f-b759-bcf6343aac86";
/>
I had considered this issue before, and I cannot directly execute `tar -C
"${APP_DIR}`. Because `directories=("connectors" "lib" "plugins")` are all
relative directories. Of course, I can also change these directories to
absolute paths, but I think `cd` changes less code. If you think using absolute
paths is more secure, I will make the modification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
