siwen-yu commented on PR #10934: URL: https://github.com/apache/seatunnel/pull/10934#issuecomment-4527306595
Thanks for the detailed review. I've reworked the fix following your Option A suggestion, taking the Oracle catalog as reference: - `DamengCreateTableSqlBuilder.build()` now returns `List<String>` directly — the `CREATE TABLE` statement is the first element, followed by individual `COMMENT ON COLUMN` statements. This avoids re-parsing SQL text in the catalog layer entirely. - `DamengCatalog` now mirrors `OracleCatalog`: `getCreateTableSqls()` directly delegates to the builder's build result, and `getCreateTableSql()` returns `getCreateTableSqls(...).get(0)`. This should resolve the semicolons-in-comments edge case from Issue 1. Regarding Issue 2 (regression tests), I'll add test coverage in a follow-up PR if that's okay. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
