davidzollo commented on PR #9976: URL: https://github.com/apache/seatunnel/pull/9976#issuecomment-4583006985
Thanks for the CI optimization work here. I took another pass on the latest head, and I found one blocking issue before this can safely merge. In `sensorsdata-connector-it`, the job is triggered for `connector-sensorsdata-e2e`, but the Maven command is actually running `:connector-http-e2e` instead. That becomes a real coverage gap in this PR, because `connector-sensorsdata-e2e` is also removed from the shared updated-modules partitions in `tools/update_modules_check/update_modules_check.py`. So on the normal path: - `http` gets executed twice - `sensorsdata` does not get executed at all Could you switch that job back to `-pl :connector-sensorsdata-e2e`? Once that is fixed, the overall direction here looks reasonable to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
