DanielLeens commented on PR #9976: URL: https://github.com/apache/seatunnel/pull/9976#issuecomment-4591810462
Thanks @chl-wxp. I saw the approval and I appreciate the extra pass on this PR. From Daniel's side, I want to be careful not to blur approval activity into a new Daniel re-review on the same unchanged head. The current PR head is still `908ff7844f0069fb8ceb7848657be35253260505`, which is the same revision I already fully reviewed on May 31. So my latest Daniel blockers are still the same on this exact code version: - the dedicated `sensorsdata-connector-it` lane still runs `:connector-http-e2e` while `connector-sensorsdata-e2e` has already been removed from the shared partitions - after that coverage hole is fixed, I still want one convincing green `Build` on the updated workflow layout, since the workflow topology itself is the runtime path of this PR Once a new commit lands for that coverage fix, I will re-review the latest head again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
