DanielLeens commented on PR #10959: URL: https://github.com/apache/seatunnel/pull/10959#issuecomment-4585287941
Thanks @davidzollo. I saw the screenshot. On the current unchanged head `deafab3c0e04cb3e2817d215ddd6ad6e98930af3`, the two blockers from the latest Daniel review are still the ones I would keep: the column-comment SQL still needs single-quote escaping in `DamengCreateTableSqlBuilder.buildColumnCommentSql(...)`, and the test expectation still needs to match the actual `createIndex=false` output. Once a new commit lands for those two points, I will re-review the new head from scratch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
