DanielLeens commented on PR #11023: URL: https://github.com/apache/seatunnel/pull/11023#issuecomment-4661735225
Thanks for calling this out, and sorry for the confusion on my side. I rechecked this specific point against the current `dev` base rather than my older local checkout, and you are right: `dev` already contains `Conditions` plus the newer `OptionRule` overloads that allow constrained `optional(...)` entries alongside `exclusive(...)`. So this particular blocker from my last review does not stand on the current base. Since there is still no new commit after Daniel's latest full review on this PR, I am not starting another full re-review in this round. Please treat this comment only as a correction to that earlier point. If you push another code update, I will re-review the latest head from scratch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
