CosmosNi commented on code in PR #11023:
URL: https://github.com/apache/seatunnel/pull/11023#discussion_r3411370210
##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/mongodb/MongodbIncrementalSourceFactory.java:
##########
@@ -114,42 +164,21 @@ private List<CatalogTable>
updateAndValidateCatalogTableId(
catalogTable.getCatalogName(),
TablePath.of(collectionName));
return Collections.singletonList(
CatalogTable.of(updatedIdentifier, catalogTable));
- } else if (!fullName.equals(collectionName)) {
Review Comment:
Why were these validation logic removed? This results in failures to detect
and handle inconsistencies between schema table names and their associated
collection names.
##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-oracle/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/oracle/config/OracleSourceConfigFactory.java:
##########
@@ -129,29 +124,16 @@ public OracleSourceConfig create(int subtask) {
.map(
tableStr -> {
String[] splits =
tableStr.split("\\.");
- if (splits.length == 2) {
- return tableStr;
- }
if (splits.length == 3) {
return String.join(".", splits[1],
splits[2]);
}
- throw new IllegalArgumentException(
- "Invalid table name: " +
tableStr);
+ return tableStr;
})
.collect(Collectors.joining(",")));
}
// override the user-defined debezium properties
if (dbzProperties != null) {
- String debeziumSchemaChanges =
Review Comment:
The validator should also check Debezium's include.schema.changes — not just
SeaTunnel's flag — since users can override it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
