Ayushkale11 commented on PR #11032: URL: https://github.com/apache/seatunnel/pull/11032#issuecomment-4666106814
@nzw921rx Thank you for the detailed review and for tracing both execution paths. You're right. I focused on migrating the validation to `OptionRule` and verified the single-table path, but I missed that `table_configs` child configurations are materialized later in `MultipleTableFakeSourceConfig.parseFromConfigs()` and therefore do not go through the same top-level validation flow. As you pointed out, removing the imperative checks from `FakeConfig.buildWithConfig()` introduces a regression for multi-table configurations. I will work on preserving validation for the child-config path and add regression tests for both: * invalid single-table configuration * invalid configuration inside `table_configs` Thank you again for the thorough review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
