DanielLeens commented on code in PR #11048:
URL: https://github.com/apache/seatunnel/pull/11048#discussion_r3401595535
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/configuration/util/ConditionEvaluators.java:
##########
@@ -169,6 +169,14 @@ private static Map<ConditionOperator, Evaluator>
createRegistry() {
return compareNumbers(v, other) >= 0;
});
+ // Extension (custom logic delegated to ConditionExtension)
+ m.put(
+ ConditionOperator.EXTENSION,
+ (v, c, cfg) -> {
+ ConditionExtension<Object> ext =
(ConditionExtension<Object>) c.getExtension();
+ return ext.evaluate(cfg, v);
Review Comment:
Thanks for raising this. Rechecking the current head, I still read the
contract here the same way the new ConditionExtension Javadoc describes it:
evaluate() may throw OptionValidationException for richer validation context,
while other unchecked exceptions are allowed to propagate rather than being
wrapped generically. So on the unchanged head I would treat the extra
catch-and-wrap as an optional troubleshooting refinement, not a new blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
