DanielLeens commented on code in PR #11048:
URL: https://github.com/apache/seatunnel/pull/11048#discussion_r3401595564
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/service/OptionRulesService.java:
##########
@@ -282,9 +282,13 @@ private OptionRuleResponse.ConditionNode
toConditionNode(Condition<?> condition)
: null;
String conditionOperator = (op != null) ? op.name() : null;
String conditionOperatorCategory = (op != null) ?
op.getCategory().name() : null;
+ Object expectValue = condition.getExpectValue();
+ if (op == ConditionOperator.EXTENSION && condition.getExtension() !=
null) {
+ expectValue = condition.getExtension().description();
+ }
Review Comment:
Same take here: I agree it is the same pattern repeated, but I do not see a
behavior bug from it on the current head. Fine as a small follow-up refactor if
the author wants to reduce duplication, but I would not reopen the approved
code path over this alone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
