julianbradford19-png commented on issue #11037: URL: https://github.com/apache/seatunnel/issues/11037#issuecomment-4739985026
Thank you for making me feel welcome. I'm excited to join the team and begin contributing right away. On Wed, Jun 17, 2026, 8:19 PM Goutam Adwant ***@***.***> wrote: > *goutamadwant* left a comment (apache/seatunnel#11037) > <https://github.com/apache/seatunnel/issues/11037#issuecomment-4736956241> > > @davidzollo <https://github.com/davidzollo> I went through the current > MySQL CDC startup and offset path before starting. > > My understanding is to keep this scoped to startup.mode = specific only. I > plan to add connector-owned options for gtid-set, skip-events and > skip-rows, then build the startup BinlogOffset from those fields so they > flow through the existing split startup offset and checkpoint/restore path. > > Validation would be: > > - specific mode requires either file+pos or gtid-set > - gtid-set is mutually exclusive with file/pos for this first delivery > - skip-events and skip-rows are only valid in specific mode and can be > used with either base offset form > - malformed GTID and negative skip values fail early > > I also noticed BinlogOffset already has gtids/event/row fields, but equal > GTID comparison appears to check restartSkipEvents without restartSkipRows. > I plan to add coverage for that and adjust it if needed. > > Test scope would be config validation, startup offset construction, > split-state restore preservation, offset comparison, and one focused MySQL > CDC runtime/IT check if it fits the existing test setup. > > Does this look right before I start changing the code ? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/seatunnel/issues/11037?email_source=notifications&email_token=B74KUG6SFPOEOAGSM56JXUD5AM7Q7A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZTGY4TKNRSGQY2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#issuecomment-4736956241>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/B74KUG2OG52KSIB46MOKZM35AM7Q7AVCNFSNUABEKJSXA33TNF2G64TZHM4TSNBRGIZTAOB3JFZXG5LFHM2DMMRZGE3TOMBXHGQXMAQ> > . > Triage notifications, keep track of coding agent tasks and review pull > requests on the go with GitHub Mobile for iOS > <https://github.com/notifications/mobile/ios/B74KUGYDJ2BOLYYJJX7N4IL5AM7Q7A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZTGY4TKNRSGQY2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ> > and Android > <https://github.com/notifications/mobile/android/B74KUG7LU2DAUYCFULQHADD5AM7Q7A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZTGY4TKNRSGQY2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ>. > Download it today! > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
