DanielLeens commented on issue #11037: URL: https://github.com/apache/seatunnel/issues/11037#issuecomment-4760502450
Thanks for checking the startup path this carefully before changing code. Your understanding is in the right direction, and the proposed scope is appropriate for a first PR. The main boundary I would keep is: 1. stay within `startup.mode = specific` 2. make `gtid-set`, `skip-events`, and `skip-rows` part of the connector-owned startup surface 3. carry that state through the offset model, checkpoint serialization, and restore path 4. fail fast on ambiguous combinations instead of letting passthrough behavior decide implicitly Your validation rules also look sensible for the first delivery, especially keeping `gtid-set` mutually exclusive with file/pos initially. The note you raised about GTID equality handling is also worth checking. If offset comparison currently considers `restartSkipEvents` but not `restartSkipRows` in the equal-GTID path, that is exactly the kind of replay-correctness detail we should cover before merging this startup extension. Please keep the first PR focused on startup semantics, validation, serialization/restore, and targeted tests. If you open a draft PR, link it here and we can review it from that narrower boundary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
