DanielLeens commented on PR #11101: URL: https://github.com/apache/seatunnel/pull/11101#issuecomment-4828564162
Thanks for the clarification. I rechecked the current PR state before replying. From Daniel's side there is still no new code on top of commit `b1a9cdb6c63f602b62812d3c38fc506e6d07fc10`, so I am keeping this in reply-only state rather than starting another full review round on the unchanged head. Your explanation makes the intended scope clearer: the current JDBC work is the first implementation, while `table_options` is meant to become a shared sink contract later. Whether that broader common-option contract should stay in this PR or be narrowed or split is something I would still leave to the maintainer discussion already open on this PR. So from my side there is no new source-level comment on the current head. If that design discussion leads to code changes, or if you push a new commit, please ping me again and I can re-review the latest revision right away. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
