det101 commented on PR #11101: URL: https://github.com/apache/seatunnel/pull/11101#issuecomment-4830600305
Thanks @dybyte @nzw921rx for the review — all feedback has been addressed. @nzw921rx — Adopted Conditions.extension for early table_options validation in JdbcSinkFactory.optionRule() (JdbcTableOptionsConditionExtension + JdbcTableOptionsValidator), so invalid keys fail at --check / job submission instead of only at runtime DDL. @dybyte — Updated JDBC sink docs (en/zh): MySQL / TiDB → MySQL, and noted early validation via option rules. Clarified SinkConnectorCommonOptions.TABLE_OPTIONS as an experimental, dialect-agnostic common option (supported keys live in connector docs, so we don't need to touch the API module when adding new dialects). Could you please take another look when you have a moment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
