nzw921rx opened a new pull request, #11214:
URL: https://github.com/apache/seatunnel/pull/11214
### Purpose of this pull request
Migrate Socket Sink configuration validation from imperative runtime checks
to declarative `OptionRule` constraints.
**Changes**:
- Add `Conditions.greaterThan` validation for `port` and `max_retries` in
`SocketSinkFactory`
- Remove the redundant `max_retries == 0` fast-fail branch from
`SocketClient`, since `max_retries` must now be greater than 0 when explicitly
configured
- Add `SocketFactoryTest` cases covering valid and invalid `port` /
`max_retries` values
### Does this PR introduce _any_ user-facing change?
Yes. Invalid Socket Sink configs (`port <= 0`, or `max_retries <= 0` when
set) are now rejected during configuration validation instead of failing later
at runtime. `max_retries = 0` is no longer accepted.
### How was this patch tested?
```bash
./mvnw -pl seatunnel-connectors-v2/connector-socket -am install -DskipTests
-Dskip.spotless=true
./mvnw -pl seatunnel-connectors-v2/connector-socket test
-Dtest=SocketFactoryTest -Dskip.spotless=true
```
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
* [ ] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR.
* [ ] If you are contributing the connector code, please check that the
following files are updated:
1. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
