DanielLeens commented on PR #11214: URL: https://github.com/apache/seatunnel/pull/11214#issuecomment-4845283850
Thanks for the clarification. I rechecked the latest head and I still see this as a backward-compatibility issue. Before this PR, `SocketClient.write(...)` explicitly accepted `max_retries = 0` as the fail-fast path: the job could still be submitted, and the connector would fail immediately on the first write error without retrying. On the current head, `SocketSinkFactory.optionRule()` rejects `0` before the sink is even created. So an existing config that used to run now fails at submission time. That is a user-visible contract change even if the eventual runtime outcome was still failure. If the goal is to keep this migration non-breaking, I still recommend preserving `max_retries >= 0` and restoring the old fail-fast zero branch. If the community intentionally wants to deprecate `0`, then it needs to be treated as an explicit incompatible change rather than hidden inside a validation cleanup. Also, this branch is currently behind the latest `dev` (`behind_by=10`, compare status: `diverged`) and the latest `Build` is still pending. After the code update, please sync the latest `dev` and rerun CI as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
