DanielLeens commented on PR #11374: URL: https://github.com/apache/seatunnel/pull/11374#issuecomment-4944507171
Thanks @SEZ9. I rechecked the same head `9233154180a3` after your follow-up review. I agree with your point that the now-correct default-value lookup is a real behavior change worth documenting, because columns without `MS_Description` will now surface `default_value` where the old buggy join path silently returned `NULL`. I would still keep that as non-blocking on this PR, though, because the current two-line SQL fix is the right source-level correction for the duplicate-row bug and Daniel's earlier blocker on the `default_constraints` join is already closed on this head. So from Daniel's side: - source blocker remains cleared on the current head - your upgrade-note or release-note point is valid, but I would treat it as a follow-up rather than a new merge blocker - the current remaining gate is still the latest `Build` failure here: https://github.com/apache/seatunnel/runs/86385064237 Happy to recheck again if a new head is pushed, but on this unchanged revision I am not reopening a new source-side blocker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
