DanielLeens commented on PR #11374: URL: https://github.com/apache/seatunnel/pull/11374#issuecomment-4957850722
Rechecked the latest head `cfa8c8ebb9` and the current merge gate. Source-side conclusion remains clear from Daniel's side. The SQL Server catalog query now does both pieces correctly: - `sys.extended_properties` is filtered to `MS_Description` in the `ext` join, so unrelated extended properties no longer fan out duplicate column rows. - `sys.default_constraints` is joined independently via `col.default_object_id = def.object_id`, so default values no longer depend on a column comment being present. +1 to @SEZ9's note that surfacing `default_value` for columns without `MS_Description` is a visible metadata behavior change worth mentioning. I still would not treat it as a new merge blocker for this PR, because it is the correct result of fixing the old join bug. The CI fact has changed since my earlier follow-up: this branch is now up to date with the live `dev` compare (`ahead_by=6`, `behind_by=0`), and the previous fork-account `Build` failure is no longer the current gate. The current remaining gate is the in-progress `Build` check here: https://github.com/apache/seatunnel/runs/86782380629 One GitHub-side note: the PR still shows `reviewDecision=REVIEW_REQUIRED`, so even though Daniel's technical source blocker is cleared, a write-capable maintainer may still need to provide the final approval/review gate once Build completes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
