DanielLeens commented on PR #10987:
URL: https://github.com/apache/seatunnel/pull/10987#issuecomment-4950909779
Rechecked the current CI gate after my previous source-clear review.
The source-side conclusion from my last review is unchanged: I still do not
see a reopened Daniel-side blocker in the MySQL timestamp-startup restore diff.
The CI fact has changed, though: the previous in-progress `Build` has now
completed as failed.
Current gate details:
```text
Apache aggregate check
-> Build: failure
-> https://github.com/apache/seatunnel/runs/86273455121
-> fork workflow run: goutamadwant/seatunnel/actions/runs/29064620856
-> failed job: Run / unit-test (11, ubuntu-latest)
-> cancelled sibling job: Run / unit-test (8, ubuntu-latest)
```
Because this PR changes connector runtime logic and the red lane is the
unit-test matrix rather than an obviously unrelated workflow/setup lane, I
would not treat this as a generic sync-only issue yet. The lowest-cost next
step is to rerun or inspect the failed unit-test lane first:
-
https://github.com/goutamadwant/seatunnel/actions/runs/29064620856/job/86314916788
If the rerun still fails, please paste the failing test snippet here and I
can help narrow it down against the current head.
### Merge conclusion: source clear, waiting for CI
Blocking items: none from Daniel's current source review.
Current merge gate: failed unit-test lane above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]