det101 opened a new pull request, #11419: URL: https://github.com/apache/seatunnel/pull/11419
## Purpose Extend JDBC sink `table_options` (SaveMode auto-create) to Dameng, as a follow-up to #11047 / #11101 / #11388. ## Changes - Add Dameng curated key whitelist: `tablespace`, `fillfactor` - Wire `DmdbDialect.validateTableOptions` and apply options in `DamengCreateTableSqlBuilder` as Dameng `STORAGE (FILLFACTOR ..., ON "...")` - Docs (en/zh): support matrix + dialect notes + Dameng example - Unit tests: dialect / DDL / OptionRule coverage ## Non-goals - Arbitrary nested `STORAGE` parameters (`INITIAL` / `NEXT` / …) - Oracle-style `PCTFREE` / `TABLESPACE` clauses (Dameng uses `STORAGE`) - `ALTER TABLE` on existing tables (`table_options` only applies when SaveMode creates the table) - E2E (unit tests only for this slice) ## Test plan - [x] `DmdbDialectTest` (supported / unsupported keys) - [x] `DamengCreateTableSqlBuilderTest#testBuildCreateTableSqlWithTableOptions` - [x] `JdbcTableOptionsConditionExtensionTest` (Dameng pass / unknown-key reject) - [ ] CI on this PR ## Related - Issue: #11047 - MySQL: #11101 - TiDB / OceanBase MySQL: #11388 - Oracle: #11416 - PostgreSQL: #11417 - Paimon: #11418 Made with [Cursor](https://cursor.com) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
