DanielLeens commented on PR #11419:
URL: https://github.com/apache/seatunnel/pull/11419#issuecomment-4968434098
Rechecked the same unchanged head `c1be135337e8` after the CI / merge-gate
fact changed.
## Runtime path rechecked
```text
JDBC sink config
-> JdbcSinkFactory.optionRule()
-> JdbcTableOptionsConditionExtension
-> JdbcTableOptionsValidator.validate(...)
-> DmdbDialect.validateTableOptions(...)
-> save-mode auto create
-> DamengCreateTableSqlBuilder.build(...)
-> append STORAGE (FILLFACTOR ..., ON ...)
```
## Merge conclusion
### Conclusion: still needs fixes before merge
1. Blocking items
- The source-side blockers from my previous Daniel review still stand on
this unchanged head.
2. Current gate update
- The CI / merge-gate fact I referenced earlier has changed. The current
status is `CI is green on the current head`:
https://github.com/apache/seatunnel/actions/runs/29304782920/job/86995812982
So my technical conclusion is unchanged on merge readiness: this PR still
needs the earlier code-side fixes first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
