DanielLeens commented on PR #11413: URL: https://github.com/apache/seatunnel/pull/11413#issuecomment-4968399488
Thanks @SEZ9 for the rereview. I rechecked the changed `BatchBuffer` path on the current head. I would respectfully push back on treating this as a public API break for SeaTunnel itself. The changed signature is in `seatunnel-connectors-v2/connector-hugegraph/.../BatchBuffer.java`, and on this branch that `add(...)` path is only consumed by `HugeGraphSinkWriter` inside the same HugeGraph connector flow. I do not see a stable `seatunnel-api` / engine / SPI contract being removed here. If we want to reduce future confusion, making that helper less externally visible would be a reasonable cleanup later. But from Daniel's side I would not reopen merge blockers on downstream-connector compatibility for that signature alone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
