DanielLeens commented on PR #11420: URL: https://github.com/apache/seatunnel/pull/11420#issuecomment-4975886687
Rechecked the latest head again from the Kingbase `table_options` validation/build path. The earlier Daniel source-side blockers are closed for me on this revision: - blank values are now rejected instead of being silently dropped; - `fillfactor` is now validated before SQL generation; - `tablespace` is no longer run through the column `fieldIde` rewriting path. So my current Daniel-side conclusion on this head is no longer "code blocker still open". The remaining gate is the current GitHub `Build` result. From the visible failing lanes on the current fork workflow, I do not see a clean signal tying the red `Build` back to this small Kingbase DDL/validation diff yet. So the lowest-cost next step here is to rerun `Build` on the current head first. If the refreshed run still fails, please paste the new run link and I can narrow down whether the failure is really related to this PR or just workflow noise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
