det101 opened a new pull request, #11420: URL: https://github.com/apache/seatunnel/pull/11420
## Purpose Extend JDBC sink `table_options` (SaveMode auto-create) to Kingbase, as a follow-up to #11047 / #11101 / #11388. ## Changes - Add Kingbase curated key whitelist: `tablespace`, `fillfactor` - Wire `KingbaseDialect.validateTableOptions` and apply options in `KingbaseCreateTableSqlBuilder` DDL (`WITH (fillfactor=...)` / `TABLESPACE "..."`) - Docs (en/zh): support matrix + dialect notes + Kingbase example - Unit tests: dialect / DDL / OptionRule coverage ## Non-goals - Arbitrary `WITH (...)` parameters - Reusing Postgres Builder/Dialect inheritance (Kingbase has an independent catalog path) - `ALTER TABLE` on existing tables (`table_options` only applies when SaveMode creates the table) - E2E (`JdbcKingbaseIT` requires a local license and is `@Disabled` by default) ## Test plan - [x] `KingbaseDialectTableOptionsTest` - [x] `KingbaseCreateTableSqlBuilderTest#testBuildWithTableOptions` - [x] `JdbcTableOptionsConditionExtensionTest` (Kingbase pass / unknown-key reject) - [ ] CI on this PR ## Related - Issue: #11047 - MySQL: #11101 - TiDB / OceanBase MySQL: #11388 - Oracle: #11416 - PostgreSQL: #11417 - Paimon: #11418 - Dameng: #11419 Made with [Cursor](https://cursor.com) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
