DanielLeens commented on PR #11186: URL: https://github.com/apache/seatunnel/pull/11186#issuecomment-4975901694
Rechecked the latest head again after the branch cleanup and the SPI split. The two earlier Daniel-side core blockers I cared about are closed for me on this revision: - the dry-run hook is no longer being forced into the stable `TableSourceFactory` / `TableSinkFactory` contract; it now sits behind separate opt-in SPI types; - the docs now make it clear that `SKIPPED` does not mean a real connector connectivity check happened, and the failure sanitization path is in place. So my current Daniel-side conclusion on this head is no longer "code blocker still open". The remaining gate looks more like the current top-level `Build` / integration-test state than a reopened source issue in the CLI dry-run path. If the current `Build` still ends red after the remaining jobs finish, please paste the failing lane link here and I can narrow down whether it is actually tied to the dry-run implementation or just broader integration noise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
