DanielLeens commented on PR #10306: URL: https://github.com/apache/seatunnel/pull/10306#issuecomment-4975901952
Rechecked the latest head again from the error-routing writer path, sink metrics path, and JDBC batch cleanup path. From Daniel's side, I do not see a reopened runtime blocker on the current revision. The earlier points I was concerned about in this PR's owned code path are closed for me now: - routed/discarded rows are no longer counted as normal sink success; - the error sink flush path is chained correctly with the parent writer lifecycle; - the JDBC batch executor no longer carries stale failed batches forward. `Build` is green on the current head, so the remaining gate here looks more like outstanding review-thread convergence than a fresh Daniel-side source blocker. I would suggest closing out the still-open reviewer discussion points explicitly in-thread, but I am not adding a new code blocker from Daniel on this head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
