zhangshenghang commented on PR #10306:
URL: https://github.com/apache/seatunnel/pull/10306#issuecomment-4988176006
Thanks for the re-review @SEZ9. I checked the JDBC writer public surface
against current `dev` for the flagged file.
What I see on head `8c94e4f686e8`:
- The existing public constructor with `SinkWriter.Context` is still present
with the same parameter list:
`JdbcSinkWriter(TablePath, SinkWriter.Context, JdbcDialect,
JdbcSinkConfig, TableSchema, TableSchema, Integer)`
- The PR adds a backward-compatible overload without `SinkWriter.Context`,
instead of removing the old constructor.
- I do not see a public/protected method removal or rename in
`JdbcSinkWriter`; the visible additions are
`SupportRowLevelErrorClassifier<SeaTunnelRow>` and `prepareCommit(long
checkpointId)`.
So this specific compatibility blocker may already be covered. Could you
point me to the exact signature you believe was removed or changed if I missed
another public surface? Once confirmed, I can adjust it directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
