DanielLeens commented on issue #11497: URL: https://github.com/apache/seatunnel/issues/11497#issuecomment-5022489211
The negative samples are credible for the tested `46d2f39` build, but there is an important current-`dev` distinction. PR #10800, merged on July 9, replaced the blocking-queue metric `inc()` / `dec()` path with `Counter#set(getIntermediateQueue().size())`. That means the exact decrement-before-increment race described here is no longer present on the current `dev` branch. I have marked this as `fixed-in-dev` for that specific failure mode. PR #11498 is proposing additional ordering and lifecycle hardening on top of the current implementation. Before treating the negative value as still reproducible on current `dev`, please rebase and repeat the sampling against the latest head. The current PR head is mergeable, but its Build check is failing, so that also needs to be resolved before the additional hardening can be evaluated. If a negative value still appears after rebasing to current `dev`, please add the exact tested commit and one matching metrics snapshot; that would show that a second path remains beyond the change from #10800. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
