DanielLeens commented on PR #11032: URL: https://github.com/apache/seatunnel/pull/11032#issuecomment-5083711741
Hi @Ayushkale11, thank you for taking on the FakeSource validation migration and for responding thoughtfully to each earlier review round. I continued directly on your original PR, rebased the two author commits onto current dev, and completed the ConditionExtension integration requested by the maintainer at 22504262e. Single-table and tables_configs child values now use the same declarative numeric constraints. OptionRule can attach a value constraint to an option already registered by an exclusive rule, child validation reports the exact tables_configs index, and the old duplicated imperative range checks have been removed. Focused tests cover the new API path plus invalid and valid nested FakeSource values. The PR is mergeable, API and connector Spotless apply/check both passed locally, and GitHub CI has started on the updated original head. Your original author commits and metadata remain intact. Thank you for sticking with a cross-layer validation change — the groundwork you provided made this completion possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
