DanielLeens commented on PR #11032: URL: https://github.com/apache/seatunnel/pull/11032#issuecomment-5117039817
Quick follow-up after the later review activity: I saw the additional change requests around the OptionRule API design. Because there is no newer commit after those comments yet, I will not treat the earlier Daniel-side `clear_waiting_ci` note as the final merge state for this head. Please address the open API/design review points first, then push an updated commit so the full OptionRule migration path can be re-reviewed against the latest code. The current `Build` check is also failing, but the source/design discussion should be resolved before we spend too much time on the CI signal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
