DanielLeens commented on PR #11575:
URL: https://github.com/apache/seatunnel/pull/11575#issuecomment-5116946475

   Quick follow-up on the gate state: the `Build` check I mentioned as still in 
progress has completed successfully on this head now.
   
   That does not change the source/docs conclusion from my previous review: the 
Socket sink documentation still needs to be adjusted so it does not describe 
the current undelimited TCP byte stream as line-framed JSON. Once that wording 
is fixed, the CI side no longer looks like a blocker from Daniel's review path.
   
   Thanks again for improving these docs. The remaining action from my side is 
just the Socket framing wording, plus the normal maintainer review/merge gate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to