zhangshenghang commented on PR #11575: URL: https://github.com/apache/seatunnel/pull/11575#issuecomment-5220999209
Thanks for the re-review. I have pushed commit 210416497 addressing the remaining feedback: - Socket source (en + zh): reworded the "empty lines are skipped" sentence. SocketSourceReader.pollNext() unconditionally collects every record the buffer splits on, including empty records, so the new wording now states that empty lines produce a row with an empty-string payload rather than being skipped. - Web3j source (en): tightened the streaming-mode intro so it no longer claims the connector "emits a row every time a new block number is observed." Web3jSourceReader.pollNext() emits a row on every poll regardless of whether the chain has produced a new block, so the new wording makes that explicit. The two cosmetic nits (table padding in Activemq / Socket docs and Jdbc/jdbc casing in the EdgeSocket example) are not blocking, but I have left them alone here to keep this follow-up focused on the correctness items; happy to address them in a separate commit if you want them folded into this PR. CI should re-run on the new head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
