DanielLeens commented on PR #10945: URL: https://github.com/apache/seatunnel/pull/10945#issuecomment-5119642145
Thanks again for the focused Dameng compatibility fix here. This PR is still valuable because `NVARCHAR2` is a real metadata-conversion gap for Dameng users, and the current change keeps the behavior aligned with the existing `NVARCHAR` path. I helped refresh the original PR branch directly instead of opening a replacement PR: - merged the latest `apache/dev` into `officialasishkumar:fix/dameng-nvarchar2-type` - kept the PR scope to the Dameng converter and its regression test - ran the scoped Spotless check for `connector-jdbc` - pushed the updated original branch to `75d2e354eb6b49b26ead42c81b01cf2b2df8865a` The PR is now mergeable from the conflict/sync side. The remaining gates are the normal GitHub CI / review gates, and the fresh workflow jobs are queued on the updated head. Appreciate the original contribution. Small type-compatibility fixes like this are exactly the kind of work that quietly makes the connector better for real users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
