DanielLeens commented on PR #10945: URL: https://github.com/apache/seatunnel/pull/10945#issuecomment-5207512502
Thanks for the ping on the updated head. I re-checked `75d2e354` against the revision I last reviewed (`f41761a0`). **Code-side: no re-review needed.** The only difference between the two commits is the `Merge remote-tracking branch 'upstream/dev'` sync commit. The PR's own files — `DmdbTypeConverter.java` and `DmdbTypeConverterTest.java` — are byte-for-byte identical between `f41761a0` and `75d2e354`. So my previous technical conclusion (Dameng `NVARCHAR2` fix is correct, no source-level blocker) still stands unchanged; there's nothing new to review on the code itself. **CI fact update.** The fork's `Build` run for `75d2e354` (https://github.com/officialasishkumar/seatunnel/actions/runs/30463565292) has now completed with conclusion `cancelled` after running ~4h9m. Breaking it down: - 32 jobs passed, including `unit-test` (JDK 11, both OS), `Code style`, `License header`, `Sanity check results`, and most of the `updated-modules-integration-test` matrix. - Only 3 jobs show `cancelled` rather than a real result (`updated-modules-integration-test-part-2` on JDK 8/11, `unit-test` on JDK 8/windows) — consistent with the whole run being cut off partway rather than any of those tests actually failing. - Exactly one job has a genuine `failure` conclusion: `oracle-cdc-connector-it (8, ubuntu-latest)`. Notably, `oracle-cdc-connector-it (11, ubuntu-latest)` on the very same commit passed. Since this PR doesn't touch anything Oracle/CDC-related, and the same suite passes on JDK 11 but fails on JDK 8 for the identical diff, this looks like an environment-flaky/unrelated-module failure rather than something introduced by this change. Net: this doesn't look like a real regression caused by the PR. The lowest-cost next step is to retrigger the `Build` workflow on the fork so we get one clean, complete run to confirm. No code changes needed from my side at this point. Good job — appreciate you sticking with this one through the CI back-and-forth. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
