DanielLeens commented on PR #10643: URL: https://github.com/apache/seatunnel/pull/10643#issuecomment-5120366143
Hi @chl-wxp, thanks for explaining the local-mode port-conflict use case and for keeping this focused on the local startup path. This is a small but practical improvement, especially for concurrent local runs and test environments. I updated this original PR branch directly: - Merged the latest `apache/dev` into `local-model-add-port-3`. - Resolved the `ClientExecuteCommand` conflict by keeping both pieces of behavior: this PR's optional Hazelcast local port override, and the latest `dev` local REST/UI default-enable logic. - Fixed the backward-compatibility blocker from the earlier review: `hazelcastPort` now defaults to `null`, so users who do not pass `--hazelcast-port` keep the historical port from `hazelcast.yaml`; only an explicitly provided CLI value overrides it. Passing `0` still intentionally requests a random port. - Ran scoped formatting: `./mvnw -nsu -Dmaven.gitcommitid.skip=true -pl seatunnel-core/seatunnel-starter,seatunnel-examples/seatunnel-engine-examples spotless:apply`. The PR now points to head `f654e36cfd6b690b36ac48450f25514416b0ea99`, and GitHub reports it as mergeable again. The current checks have just been queued, so the remaining gate is the normal GitHub CI/review result. Appreciate the contribution — this keeps the original discussion and review trail intact. 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
