davidzollo commented on PR #11567: URL: https://github.com/apache/seatunnel/pull/11567#issuecomment-5133039052
Thanks for the detailed lifecycle review. The blocker has been addressed in `cac6234453`. What changed: - each multi-table writer now retains its connection-group `ClientResource` during resource injection; - `ElasticsearchSinkWriter.close()` releases that retained resource exactly once; - `ElasticsearchMultiTableResourceManager` closes and removes a connection group only when the last active writer releases it; - manager-level `close()` remains the final cleanup fallback and does not double-close groups already removed by per-writer release. Coverage was updated for both requested cases: - closing one writer in a shared group does not close the client while another writer still uses it; - closing the last writer of a unique/shared group closes and removes that client without waiting for the whole multi-table sink to stop. Local validation run here is limited to scoped Spotless per the Apache SeaTunnel workflow rule; functional verification is left to GitHub CI on the new head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
