davidzollo commented on PR #11567: URL: https://github.com/apache/seatunnel/pull/11567#issuecomment-5138483193
Current head `6c7720603f1e` has already addressed the previous lifecycle blocker and the required Build is green: https://github.com/apache/seatunnel/runs/90947154879 What changed after the review: - `ElasticsearchMultiTableResourceManager` now retains a per-connection-group `ClientResource` for each injected table writer. - `ElasticsearchSinkWriter.close()` releases the retained resource exactly once; the manager removes and closes the REST client when the reference count reaches zero. - Closing one writer no longer closes a client still used by another writer, while closing the last writer of a shared or unique group releases it without waiting for the whole multi-table sink to stop. - Added tests for shared-group close, isolated connection close, partial initialization failure, serializer initialization failure, and standalone writer ownership. Could you please re-review this latest head and clear the stale review gate if it looks good? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
