PDGGK commented on PR #10532:
URL: https://github.com/apache/seatunnel/pull/10532#issuecomment-5157029241
Thanks for re-reviewing @DanielLeens. I think Issue 1 is a base-comparison
artefact rather than something in this PR — could you re-check it against the
current base?
This PR touches two files, both under `connector-file-base`:
```
$ gh api repos/apache/seatunnel/pulls/10532/files \
--jq '.[] | "\(.status) +\(.additions)/-\(.deletions) \(.filename)"'
modified +16/-15
.../connector-file-base/src/main/java/.../source/reader/AbstractReadStrategy.java
added +180/-0
.../connector-file-base/src/test/java/.../source/reader/AbstractReadStrategyGzCloseTest.java
```
and the two commits touch one file each — `a0a33360` the fix, `5dbd3f3b` the
test. Nothing under `seatunnel-ci-tools/`.
The `ImportClassCheckTest` work you describe — `ImportMetadata`, skipping
`target` paths, protobuf-generated-source detection, the import line-number
rework — is @danielnadean's, in #11623 (`458cefdc5`, merged to `dev` earlier
today at 05:52 UTC) and #11621 (`16101418`). `458cefdc5` is the commit I
rebased onto, so it is this PR's base:
```
$ gh pr view 10532 --json baseRefOid --jq .baseRefOid
458cefdc516a4fe95fe2c5cabf6b7eeb9f650d13
```
So it appears in the diff whenever the comparison is taken against a `dev`
checkout from before 05:52 UTC — my base commit then shows up as if it were
part of the branch. There is nothing for me to drop, since the file is not in
the PR; if you still see it after fetching `dev`, please tell me what base SHA
you are comparing against and I will take another look.
One other update while you are here: the required `Build` has since finished
green on this head (`5dbd3f3b`, 2h24m) —
https://github.com/apache/seatunnel/runs/91465377629. That was the outstanding
gate from your 07-30 note, so with the import-scan point resolved I think this
one is ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
