PDGGK commented on PR #10532:
URL: https://github.com/apache/seatunnel/pull/10532#issuecomment-5157041576
Thanks for re-reviewing the rebuilt head — and glad the
`AbstractReadStrategy` cleanup and `AbstractReadStrategyGzCloseTest` read well
to you.
On Issue 1: `ImportClassCheckTest.java` is not in this PR. You cite head
`5dbd3f3bdf5583fa1eb6e16663044a4c161c4d2d`, which is the current head, and at
that commit the PR contains exactly two files:
```
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/.../source/reader/AbstractReadStrategy.java
+16 −15
seatunnel-connectors-v2/connector-file/connector-file-base/src/test/java/.../source/reader/AbstractReadStrategyGzCloseTest.java
+180 −0
```
That is the full `GET /repos/apache/seatunnel/pulls/10532/files` response,
and `ImportClassCheck` does not appear anywhere in `gh pr diff 10532`. The two
commits on the branch are the GZ fix and its regression test; there is no
`seatunnel-ci-tools` change, no `ImportMetadata`, and nothing touching the
import scanner.
Could you re-run the check against `5dbd3f3` directly? If you are still
seeing a `seatunnel-ci-tools` change in the diff I would genuinely like to know
which API call surfaces it, since I cannot reproduce it from the PR files
endpoint or the diff. If it is a cached diff from before the branch was
rebuilt, that would explain it.
Otherwise the scope is already what you are asking for — the GZ resource fix
plus its focused regression test, nothing else — and the required `Build` is
green on this head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]