DanielLeens commented on PR #10238: URL: https://github.com/apache/seatunnel/pull/10238#issuecomment-5178100146
Following up after @SEZ9's `LGTM, can merge`. I agree with their conclusion — no source-level blocker from my side on the current StarRocks BE host/port mapping diff, so we are aligned on the code. The blockers here are mechanical rather than technical, and I want to lay them out in the order that will cost you the least: 1. **Merge conflicts.** GitHub reports this branch as conflicting with `dev` (`mergeable_state=dirty`). Nothing can proceed until that is resolved. 2. **The branch is very far behind** — `behind_by=583`, compare status `diverged`. That is why the only `Build` result attached to this head is the run from July 26, and why its non-green jobs (`unit-test (11, ubuntu-latest)`, `Build website`) look nothing like a BE host/port mapping change. That signal cannot be interpreted. So: sync with the latest `dev`, resolve the conflicts, and push. CI will then produce a result that actually reflects your diff. If the same lanes are still red on the refreshed head, please paste the fresh failing job links here and I will help narrow them down against the updated base. I appreciate that this PR has been open a long time and the rebase will not be trivial at 583 commits behind — but the code itself is agreed by two reviewers now, so the refresh really is the last substantive step before a committer can approve and merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
