SEZ9 commented on PR #10238: URL: https://github.com/apache/seatunnel/pull/10238#issuecomment-5381236445
@DanielLeens Thanks for the clear follow-up, and apologies for the delayed answer. To answer you directly: I agree with your assessment. The code side is settled — the mapping work you completed at 2952d0553 covers the endpoint-safety concerns, and there is no source-level blocker remaining on the StarRocks BE host/port mapping diff itself. On your two mechanical points: 1. **Merge conflicts** — not resolved yet. Nothing has been pushed since your comment, so the branch is still conflicting with `dev`. 2. **Stale CI signal** — agreed. The only Build result attached to this head is still the July 26 run (https://github.com/apache/seatunnel/runs/89797556787), and I agree its non-green jobs (`unit-test (11, ubuntu-latest)`, `Build website`) cannot be meaningfully interpreted against a diff this far behind (`behind_by=583`, diverged). Concrete remaining asks before this can be merged: - Sync the branch with the latest `dev`, resolve the conflicts, and push the refreshed head. - Let CI run on that refreshed head so we finally have a result that reflects this diff. - If any lanes are still red afterwards, paste the fresh failing job links in this thread — per your offer, that would be the point to narrow them down against the updated base. Once the branch is refreshed and CI is green, I'm ready to approve and merge — as you said, the code is agreed and the rebase is the last substantive step. <!-- streview-comment:445 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
