SEZ9 commented on PR #11659: URL: https://github.com/apache/seatunnel/pull/11659#issuecomment-5201963791
@DanielLeens Fixed in head `2794225` — and thanks for framing Issue 1 the way you did: the "weaker models imitate concrete examples over prose caveats" argument from this PR's own commit message applies verbatim, so leaving the Pattern template contradicting the corrected prose would indeed have undermined exactly the fix that just landed. Applied Option A, plus the two prose lines you located: - **Pattern template** (`cdc_realtime.md` Pattern block): the singular keys now carry an inline HOCON comment directly above them showing PostgreSQL-CDC's real convention (`database-names = ["<database>"]` / `table-names = ["<database>.<schema>.<table>"]`, plural, list-typed, fully qualified) and pointing to `get_connector_info` for exact keys. - **SOP step 4**: no longer enumerates `database-name, table-name` as if universal — now says the database/table selection keys vary by connector, with the PostgreSQL plural forms called out. - **Constraints**: the hyphens-not-underscores rule now uses `database-name`/`database-names` as its example instead of asserting the singular form as the one true convention. The remaining singular keys in the generic MySQL-oriented prose (lines 50–54) are untouched: they're accurate for the MySQL-CDC family the file's generic sections describe, and rewriting them is beyond what this PR should carry. One process note for transparency: while pushing this round I force-pushed over a `Merge branch 'dev'` sync commit that had been added to the branch head. No review changes were lost — it contained only the dev-side sync (the HugeGraph connector merge) — and the PR is mergeable against current dev. Apologies for the noise; subsequent updates will fast-forward. Full suite: 76 passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
