SEZ9 commented on PR #11659: URL: https://github.com/apache/seatunnel/pull/11659#issuecomment-5242513101
@DanielLeens All four items fixed in `14e8d1a` (fast-forward on the current head this time). First — apologies for leaving your 2026-08-06T13:13 comment unanswered for four days; the findings were correct then and re-confirmed now, and the formal state flip was the right call. **Issue 1 (blocker) — PostgreSQL-CDC format guidance corrected, direction reversed**: the section now states the canonical two-part `schema.table` form (citing the connector's own error message), notes that three-part entries are accepted but the leading database segment is silently dropped without filtering, and points database selection at `database-names` instead. The comparison-table row now reads `schema.table (canonical)`. You were right that my round-1 "fix" pointed the wrong way — I corrected it from the docs and stopped at the option definitions without reading `PostgresSourceConfigFactory`'s actual split-handling. Parser behavior beats documentation; lesson applied. **Issue 2 (blocker) — template body actually fixed this time**: the Pattern template now uses `database-names = ["<database>"]` / `table-names = [...]` with a one-line inline note for the per-connector entry formats (`database.table` for MySQL-CDC, `schema.table` for PostgreSQL-CDC). The caveat comment that papered over the singular keys is gone along with the singular keys themselves. **Issue 3 — FieldMapper direction aligned**: `id = order_id`, consistent with `amount = total` (key = existing input field, value = new output name). **Issue 4 — wording softened**: `database-names` no longer claims to scope monitoring across the list; the text now says the connector connects to the first listed database. The PR description's PostgreSQL-CDC summary is also synced to match the shipped content (it still carried the round-1 wording, which would have become the squash commit message). Full suite: 76 passed at the new head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
