li3zhi4 commented on PR #11677: URL: https://github.com/apache/seatunnel/pull/11677#issuecomment-5211413297
All five review issues have been addressed in the new commit `8ce669eb6`: - **Issue 1 (High)**: e2e `Thread.sleep(12)` replaced with a condition-based await on `container.getCompletedCheckpointCount(jobId) > 0` — waits until the snapshot state is durably checkpointed instead of a hard sleep. - **Issue 4 (Low)**: the log-keyword readiness check is replaced with a structured signal — waits until the job state leaves `RUNNING` after the injected sink failure (observable because `job.retry.interval` is 15s). - **Issue 5 (Low)**: added a comment explaining why `addSplitsBack()` re-runs `assignSplits()`. - **Issue 2 (Medium)**: corrected the `SourceSplitEnumerator.run()` Javadoc — implementations must not rely on a strict invocation order; restored splits may arrive after the reader's split request. - **Issue 3 (Low)**: softened the issue/PR wording from an unrecoverable hang to a bounded stall. Verified: spotless:check passes on all three affected modules and the unit test `IncrementalSourceEnumeratorTest` passes (1/1). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
