li3zhi4 commented on PR #11677: URL: https://github.com/apache/seatunnel/pull/11677#issuecomment-5235230618
Thanks @SEZ9 — all three pre-merge asks are addressed in the squashed head `d343a51be`: 1. **Test comment added**: the e2e test now carries a comment at the top of `testMysqlCdcContinuesAfterSinkFailure` stating that with `parallelism = 1` this clean full-pipeline restart drives the pre-existing `handleSplitRequest()` dispatch path and serves as a regression guard, while the new `running == true` branch in `addSplitsBack()` is covered deterministically by `IncrementalSourceEnumeratorTest#shouldAssignRestoredSplitsToWaitingReader`. 2. **History squashed**: the four commits (fix+unit test, e2e+conf, two review-fix commits) are now a single clean commit `d343a51be` (6 files, +322/-5), forced-pushed with `--force-with-lease`. 3. **E2E stability**: spotless:check passes on all four affected modules, the unit test passes 1/1, and the e2e module test-compiles. I've re-triggered nothing extra locally yet — if you'd like, I can push an empty commit or rely on the CI run on this new head to confirm the state-based waits (completed-checkpoint-count and job-state transition) don't flake around the 15s `job.retry.interval` window under CI load. Please let me know if you'd prefer I do that, or if the fresh CI run on `d343a51be` suffices. Also noting: the debug-log trace of a real partial-restart interleaving remains a nice-to-have follow-up, as agreed — not holding this PR for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
